Messages in this thread | | | Subject | Re: [PATCH v2] clk: at91: add sama5d3 pmc driver | From | Ahmad Fatoum <> | Date | Fri, 3 Jul 2020 09:34:43 +0200 |
| |
Hello Alexandre,
On 6/22/20 11:47 PM, Alexandre Belloni wrote: > Hi, > > On 22/06/2020 23:24:45+0200, Ahmad Fatoum wrote: >>> + regmap = syscon_node_to_regmap(np); >> >> Shouldn't this be device_node_to_regmap for the same reasons outlined in your >> 6956eb33 ("clk: at91: fix possible deadlock") commit? >> >> Same question for at91sam9g45.c, sam9x60.c and at91sam9n12.c. >> > > Agreed, I guess you can send a patch fixing all the instances.
I just sent out a patch for those 4 files. I don't know if this issue is equally applicable to the dt-compat.c code, so I left that one as is.
Cheers, Ahmad
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |