Messages in this thread | | | Date | Wed, 29 Jul 2020 08:39:57 -0400 | From | Joel Fernandes <> | Subject | Re: [PATCH RFC] rcu/segcblist: Add counters to segcblist datastructure |
| |
On Mon, Jul 20, 2020 at 07:29:23AM -0700, Davidlohr Bueso wrote: > On Sat, 18 Jul 2020, Joel Fernandes (Google) wrote: > > > +/* Move from's segment length to to's segment. */ > > +static void rcu_segcblist_move_seglen(struct rcu_segcblist *rsclp, int from, int to) > > +{ > > + long len = rcu_segcblist_get_seglen(rsclp, from); > > + > > + if (!len || from == to) > > + return; > > Nit: You probably wanna do the parameter sanity checks before the > atomic_read.
Ok, I'll do that next revision. Thank you.
- Joel
| |