lkml.org 
[lkml]   [2020]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: sun50i-pinephone: add led flash
Hi!

On Sat, Jul 25, 2020 at 01:08:12PM +0200, Luca Weiss wrote:
> All revisions of the PinePhone have an SGM3140 LED flash. The gpios were
> swapped on v1.0 of the board but this was fixed in later revisions.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> .../boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 5 +++++
> .../boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 5 +++++
> .../boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts | 5 +++++
> .../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 11 +++++++++++
> 4 files changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
> index 0c42272106afa..b579b03d4e026 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts
> @@ -9,3 +9,8 @@ / {
> model = "Pine64 PinePhone Developer Batch (1.0)";
> compatible = "pine64,pinephone-1.0", "allwinner,sun50i-a64";
> };
> +
> +&sgm3140 {
> + flash-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> + enable-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */
> +};
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
> index 3e99a87e9ce52..8552587aac248 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts
> @@ -28,3 +28,8 @@ &backlight {
> num-interpolated-steps = <50>;
> default-brightness-level = <400>;
> };
> +
> +&sgm3140 {
> + flash-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */
> + enable-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> +};
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> index a9f5b670c9b82..ec77715ba4a2a 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.2.dts
> @@ -38,3 +38,8 @@ &lis3mdl {
> interrupt-parent = <&pio>;
> interrupts = <1 1 IRQ_TYPE_EDGE_RISING>; /* PB1 */
> };
> +
> +&sgm3140 {
> + flash-gpios = <&pio 2 3 GPIO_ACTIVE_HIGH>; /* PC3 */
> + enable-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
> +};
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index 25150aba749dc..e0bc1bcc1c1f3 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -60,6 +60,17 @@ vibrator {
> enable-gpios = <&pio 3 2 GPIO_ACTIVE_HIGH>; /* PD2 */
> vcc-supply = <&reg_dcdc1>;
> };
> +
> + sgm3140: led-controller {

The nodes should be ordered by node-name here

> + compatible = "sgmicro,sgm3140";
> + vin-supply = <&reg_dcdc1>;
> +
> + sgm3140_flash: led {

What do you need the label for?

Thanks!
Maxime
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-29 14:35    [W:0.147 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site