lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH bpf-next v2 22/35] bpf: eliminate rlimit-based memory accounting for bpf ringbuffer
    On Mon, Jul 27, 2020 at 12:21 PM Roman Gushchin <guro@fb.com> wrote:
    >
    > Do not use rlimit-based memory accounting for bpf ringbuffer.
    > It has been replaced with the memcg-based memory accounting.
    >
    > bpf_ringbuf_alloc() can't return anything except ERR_PTR(-ENOMEM)
    > and a valid pointer, so to simplify the code make it return NULL
    > in the first case. This allows to drop a couple of lines in
    > ringbuf_map_alloc() and also makes it look similar to other memory
    > allocating function like kmalloc().
    >
    > Signed-off-by: Roman Gushchin <guro@fb.com>
    > ---

    LGTM.

    Acked-by: Andrii Nakryiko <andriin@fb.com>

    > kernel/bpf/ringbuf.c | 24 ++++--------------------
    > 1 file changed, 4 insertions(+), 20 deletions(-)
    >

    [...]

    \
     
     \ /
      Last update: 2020-07-28 07:57    [W:4.217 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site