lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone
From
Date
On 27.07.20 14:02, Pavel Machek wrote:
> Hi!
>
>> + pwmleds {
>> + compatible = "pwm-leds";
>> +
>> + blue {
>> + label = "blue:status";
>> + max-brightness = <248>;
>> + pwms = <&pwm2 0 50000>;
>> + };
>> +
>> + green {
>> + label = "green:status";
>> + max-brightness = <248>;
>> + pwms = <&pwm4 0 50000>;
>> + };
>> +
>> + red {
>> + label = "red:status";
>> + max-brightness = <248>;
>> + pwms = <&pwm3 0 50000>;
>> + };
>> + };
>
> Can we postpone this?

I guess we can. It's indeed easier to add that interface once we know we
can use a stable one.

>
> 1) green:status is not really name used anywhere else
>
> 2) this should really use multicolor framework, as it is single LED,
> not three of them.
>
> Fixing that in future will be hard :-(.
> Pavel
>
>

thanks,
martin

\
 
 \ /
  Last update: 2020-07-28 12:44    [W:0.109 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site