Messages in this thread | | | Date | Tue, 28 Jul 2020 09:12:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH] tty/synclink: remove leftover bits of non-PCI card support |
| |
On Tue, Jul 28, 2020 at 08:40:25AM +0200, Jiri Slaby wrote: > On 28. 07. 20, 8:20, Christoph Hellwig wrote: > > On Tue, Jul 28, 2020 at 08:05:36AM +0200, Jiri Slaby wrote: > >> On 27. 07. 20, 15:05, Christoph Hellwig wrote: > >>> Since commit 1355cba9c3ba ("tty/synclink: remove ISA support"), the > >>> synlink driver only supports PCI card. Remove any leftover dead code > >>> to support other cards. > >> > >> So now you can remove also the defines and bus_type completely: > >> $ git grep -E 'MGSL_BUS_TYPE_(E?ISA|PCI)' > >> drivers/tty/synclink_gt.c: info->bus_type = MGSL_BUS_TYPE_PCI; > >> drivers/tty/synclinkmp.c: info->bus_type = MGSL_BUS_TYPE_PCI; > >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_ISA 1 > >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_EISA 2 > >> include/uapi/linux/synclink.h:#define MGSL_BUS_TYPE_PCI 5 > > > > This is in a uapi header, so I didn't dare to touch it. > > Ah, sure. Then OK. > > Just wondering, who would place this into a uapi header?
People didn't realize they were uapi headers a long time ago, when everything was in the same directory/files :(
thanks,
greg k-h
| |