Messages in this thread | | | Date | Tue, 28 Jul 2020 22:01:06 -0400 | From | Richard Guy Briggs <> | Subject | Re: [PATCH V3fix ghak120] audit: initialize context values in case of mandatory events |
| |
On 2020-07-28 14:47, Paul Moore wrote: > On Tue, Jul 28, 2020 at 12:27 PM Richard Guy Briggs <rgb@redhat.com> wrote: > > I know you like only really minimal fixes this late, but this seemed > > pretty minimal to me... > > Minimal is a one (two?) line NULL check in audit_log_name(), this > patch is not that.
I didn't try and test that since I'm not sure that would have worked because there appeared to be a low non-NULL value in it. brauer1's trace had 0x60 and mine had 0xd0. Or am I missing something obvious?
The patch provided the information rather than ignoring the problem (which maybe should have been caught by WARN_ONCE?).
> paul moore
- RGB
-- Richard Guy Briggs <rgb@redhat.com> Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635
| |