lkml.org 
[lkml]   [2020]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] greybus: Use fallthrough pseudo-keyword
From
Date
On Tue, 2020-07-28 at 17:37 -0500, Alex Elder wrote:
> On 7/27/20 1:32 PM, Gustavo A. R. Silva wrote:
> > Replace the existing /* fall through */ comments and its variants with
> > the new pseudo-keyword macro fallthrough[1].
> >
> > [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
>
> Thanks for the patch. It looks good, but it raises
> another question I'd like discussion on.
>
> It seems that Johan likes default (or final) cases in
> switch statements without a "break" statement. Viresh
> and Bryan appear to be fond of this too.
>
> It's pedantic, but I don't like that. Am I wrong?

No, you are not wrong.


\
 
 \ /
  Last update: 2020-07-29 02:27    [W:0.069 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site