lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 046/179] fpga: dfl: pci: reduce the scope of variable ret
    Date
    From: Xu Yilun <yilun.xu@intel.com>

    [ Upstream commit e19485dc7a0d210b428a249c0595769bd495fb71 ]

    This is to fix lkp cppcheck warnings:

    drivers/fpga/dfl-pci.c:230:6: warning: The scope of the variable 'ret' can be reduced. [variableScope]
    int ret = 0;
    ^

    drivers/fpga/dfl-pci.c:230:10: warning: Variable 'ret' is assigned a value that is never used. [unreadVariable]
    int ret = 0;
    ^

    Fixes: 3c2760b78f90 ("fpga: dfl: pci: fix return value of cci_pci_sriov_configure")
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Xu Yilun <yilun.xu@intel.com>
    Acked-by: Wu Hao <hao.wu@intel.com>
    Reviewed-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Moritz Fischer <mdf@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/fpga/dfl-pci.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
    index 538755062ab7c..a78c409bf2c44 100644
    --- a/drivers/fpga/dfl-pci.c
    +++ b/drivers/fpga/dfl-pci.c
    @@ -227,7 +227,6 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
    {
    struct cci_drvdata *drvdata = pci_get_drvdata(pcidev);
    struct dfl_fpga_cdev *cdev = drvdata->cdev;
    - int ret = 0;

    if (!num_vfs) {
    /*
    @@ -239,6 +238,8 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs)
    dfl_fpga_cdev_config_ports_pf(cdev);

    } else {
    + int ret;
    +
    /*
    * before enable SRIOV, put released ports into VF access mode
    * first of all.
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-27 16:21    [W:4.060 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site