lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] qed: fix assignment of n_rq_elems to incorrect params field
Date
From: Colin Ian King <colin.king@canonical.com>

Currently n_rq_elems is being assigned to params.elem_size instead of the
field params.num_elems. Coverity is detecting this as a double assingment
to params.elem_size and reporting this as an usused value on the first
assignment. Fix this.

Addresses-Coverity: ("Unused value")
Fixes: b6db3f71c976 ("qed: simplify chain allocation with init params struct")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/qedr/verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index 5a80471577a6..4ce4e2eef6cc 100644
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -1930,7 +1930,7 @@ qedr_roce_create_kernel_qp(struct qedr_dev *dev,
in_params->sq_pbl_ptr = qed_chain_get_pbl_phys(&qp->sq.pbl);

params.intended_use = QED_CHAIN_USE_TO_CONSUME_PRODUCE;
- params.elem_size = n_rq_elems;
+ params.num_elems = n_rq_elems;
params.elem_size = QEDR_RQE_ELEMENT_SIZE;

rc = dev->ops->common->chain_alloc(dev->cdev, &qp->rq.pbl, &params);
--
2.27.0
\
 
 \ /
  Last update: 2020-07-27 16:18    [W:0.074 / U:0.952 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site