lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: improve MAINTAINERS file update test
From
Date
On Mon, 2020-07-27 at 15:58 -0500, Daniel Dadap wrote:
> Add an additional regular expression to detect updates to the
> MAINTAINERS file as reported in the unified diffs generated by
> `git format-patch`. This suppresses the "does MAINTAINERS need
> updating" message when MAINTAINERS is updated with this format.

Please cc at least LKML.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2621,7 +2621,8 @@ sub process {
>
> # Check if MAINTAINERS is being updated. If so, there's probably no need to
> # emit the "does MAINTAINERS need updating?" message on file add/move/delete
> - if ($line =~ /^\s*MAINTAINERS\s*\|/) {
> + if ($line =~ /^\s*MAINTAINERS\s*\|/ ||
> + $line =~ /^[-+]{3} [ab]\/MAINTAINERS$/) {

I don't believe this works well as any test
for a file modification to MAINTAINERS occurs
after the block that would show a diffstat
where the warning is emitted.


\
 
 \ /
  Last update: 2020-07-27 23:08    [W:0.045 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site