lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache
From
Date


> On Jul 27, 2020, at 3:17 PM, Sasha Levin <sashal@kernel.org> wrote:
>
> On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote:
>>
>>
>>> On Jul 27, 2020, at 2:18 PM, Sasha Levin <sashal@kernel.org> wrote:
>>>
>>> On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote:
>>>> This mail needs to be saent to stable@vger.kernel.org (now cc'd).
>>>>
>>>> Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>>
>>> Hm, what's the issue that this patch addresses? It's not clear from the
>>> commit message.
>>>
>>> --
>>> Thanks,
>>> Sasha
>>
>> HI Sasha ,
>>
>> In an off-line conversation I had with Mike , he indicated that :
>>
>>
>> commit 1b17159e52bb31f982f82a6278acd7fab1d3f67b
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date: Fri Feb 28 18:00:53 2020 -0500
>>
>> dm bio record: save/restore bi_end_io and bi_integrity
>>
>>
>> commit 248aa2645aa7fc9175d1107c2593cc90d4af5a4e
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date: Fri Feb 28 18:11:53 2020 -0500
>>
>> dm integrity: use dm_bio_record and dm_bio_restore
>>
>>
>> Were picked up in "stable" kernels picked up even though
>> neither was marked for stable@vger.kernel.org
>>
>> Adding this missing commit :
>>
>> 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>
>>
>> Completes the series
>
> Should we just revert those two commits instead if they're not needed?
>
> --
> Thanks,
> Sasha

As I stated above:

> Fixes: 705559706d62038b74c5088114c1799cf2c9dce8 (dm bio record:
> save/restore bi_end_io and bi_integrity, version 4.14.188)
>
> 70555970 introduced a mkfs.ext4 hang on a LVM device that has been
> modified with lvconvert --cachemode=writethrough.

It corrects an issue we discovered in 4.14.188 . Any other branches those two commits have migrated to will likely have the same regression.

I am confident linux-4.14.y will be better off with it ;-)




\
 
 \ /
  Last update: 2020-07-27 22:41    [W:0.100 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site