lkml.org 
[lkml]   [2020]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 001/138] soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner
    Date
    From: Douglas Anderson <dianders@chromium.org>

    commit 35bb4b22f606c0cc8eedf567313adc18161b1af4 upstream.

    Adding an item into the cache should never be able to make the cache
    cleaner. Use "|=" rather than "=" to update the dirty flag.

    Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
    Reviewed-by: Maulik Shah <mkshah@codeaurora.org> Thanks, Maulik
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Fixes: bb7000677a1b ("soc: qcom: rpmh: Update dirty flag only when data changes")
    Reported-by: Stephen Boyd <swboyd@chromium.org>
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    Link: https://lore.kernel.org/r/20200417141531.1.Ia4b74158497213eabad7c3d474c50bfccb3f342e@changeid
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/soc/qcom/rpmh.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/soc/qcom/rpmh.c
    +++ b/drivers/soc/qcom/rpmh.c
    @@ -150,10 +150,10 @@ existing:
    break;
    }

    - ctrlr->dirty = (req->sleep_val != old_sleep_val ||
    - req->wake_val != old_wake_val) &&
    - req->sleep_val != UINT_MAX &&
    - req->wake_val != UINT_MAX;
    + ctrlr->dirty |= (req->sleep_val != old_sleep_val ||
    + req->wake_val != old_wake_val) &&
    + req->sleep_val != UINT_MAX &&
    + req->wake_val != UINT_MAX;

    unlock:
    spin_unlock_irqrestore(&ctrlr->cache_lock, flags);

    \
     
     \ /
      Last update: 2020-07-27 16:38    [W:4.249 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site