lkml.org 
[lkml]   [2020]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH v2 1/4] fpga: dfl: change data type of feature id to u16
    From
    Date
    It would be good if the variable or element for the feature id had a consistent name.


    > @@ -197,7 +197,7 @@ int dfl_fpga_check_port_id(struct platform_device *pdev, void *pport_id);
    > * @id: unique dfl private feature id.
    > */
    > struct dfl_feature_id {
    > - u64 id;
    > + u16 id;
    > };

    Is this structure needed ?

    Here is how it could be changed to 

    struct dfl_feature_driver {

    -    const dfl_feature_id *

    +    const u16 *id_table;

    ...

    Tom


    >
    > /**
    > @@ -240,7 +240,7 @@ struct dfl_feature_irq_ctx {
    > */
    > struct dfl_feature {
    > struct platform_device *dev;
    > - u64 id;
    > + u16 id;
    > int resource_index;
    > void __iomem *ioaddr;
    > struct dfl_feature_irq_ctx *irq_ctx;
    > @@ -371,7 +371,7 @@ struct platform_device *dfl_fpga_inode_to_feature_dev(struct inode *inode)
    > (feature) < (pdata)->features + (pdata)->num; (feature)++)
    >
    > static inline
    > -struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u64 id)
    > +struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u16 id)
    > {
    > struct dfl_feature_platform_data *pdata = dev_get_platdata(dev);
    > struct dfl_feature *feature;
    > @@ -384,7 +384,7 @@ struct dfl_feature *dfl_get_feature_by_id(struct device *dev, u64 id)
    > }
    >
    > static inline
    > -void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u64 id)
    > +void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u16 id)
    > {
    > struct dfl_feature *feature = dfl_get_feature_by_id(dev, id);
    >
    > @@ -395,7 +395,7 @@ void __iomem *dfl_get_feature_ioaddr_by_id(struct device *dev, u64 id)
    > return NULL;
    > }
    >
    > -static inline bool is_dfl_feature_present(struct device *dev, u64 id)
    > +static inline bool is_dfl_feature_present(struct device *dev, u16 id)
    > {
    > return !!dfl_get_feature_ioaddr_by_id(dev, id);
    > }

    \
     
     \ /
      Last update: 2020-07-25 15:30    [W:2.812 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site