lkml.org 
[lkml]   [2020]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 1/6] fs: introduce FMODE_ZONE_APPEND and IOCB_ZONE_APPEND
    From
    Date
    On 7/24/20 9:49 AM, Kanchan Joshi wrote:
    > diff --git a/include/linux/fs.h b/include/linux/fs.h
    > index 6c4ab4d..ef13df4 100644
    > --- a/include/linux/fs.h
    > +++ b/include/linux/fs.h
    > @@ -175,6 +175,9 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset,
    > /* File does not contribute to nr_files count */
    > #define FMODE_NOACCOUNT ((__force fmode_t)0x20000000)
    >
    > +/* File can support zone-append */
    > +#define FMODE_ZONE_APPEND ((__force fmode_t)0x40000000)

    This conflicts with the async buffered read support in linux-next that
    has been queued up for a long time.

    > @@ -315,6 +318,7 @@ enum rw_hint {
    > #define IOCB_SYNC (1 << 5)
    > #define IOCB_WRITE (1 << 6)
    > #define IOCB_NOWAIT (1 << 7)
    > +#define IOCB_ZONE_APPEND (1 << 8)

    Ditto this one, and that also clashes with mainline. The next available
    bit would be 10, IOCB_WAITQ and IOCB_NOIO are 8 and 9.


    --
    Jens Axboe

    \
     
     \ /
      Last update: 2020-07-24 18:34    [W:4.043 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site