lkml.org 
[lkml]   [2020]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 2/6] fs: change ki_complete interface to support 64bit ret2
    Date
    From: SelvaKumar S <selvakuma.s1@samsung.com>

    kiocb->ki_complete(...,long ret2) - change ret2 to long long.
    This becomes handy to return 64bit written-offset with appending write.
    Change callers using ki_complete prototype.

    Signed-off-by: SelvaKumar S <selvakuma.s1@samsung.com>
    Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
    Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
    Signed-off-by: Javier Gonzalez <javier.gonz@samsung.com>
    ---
    drivers/block/loop.c | 2 +-
    drivers/nvme/target/io-cmd-file.c | 2 +-
    drivers/target/target_core_file.c | 2 +-
    fs/aio.c | 2 +-
    fs/io_uring.c | 4 ++--
    fs/overlayfs/file.c | 2 +-
    include/linux/fs.h | 2 +-
    7 files changed, 8 insertions(+), 8 deletions(-)

    diff --git a/drivers/block/loop.c b/drivers/block/loop.c
    index c33bbbf..d41dcbd 100644
    --- a/drivers/block/loop.c
    +++ b/drivers/block/loop.c
    @@ -512,7 +512,7 @@ static void lo_rw_aio_do_completion(struct loop_cmd *cmd)
    blk_mq_complete_request(rq);
    }

    -static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long ret2)
    +static void lo_rw_aio_complete(struct kiocb *iocb, long ret, long long ret2)
    {
    struct loop_cmd *cmd = container_of(iocb, struct loop_cmd, iocb);

    diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c
    index 0abbefd..ae6e797 100644
    --- a/drivers/nvme/target/io-cmd-file.c
    +++ b/drivers/nvme/target/io-cmd-file.c
    @@ -123,7 +123,7 @@ static ssize_t nvmet_file_submit_bvec(struct nvmet_req *req, loff_t pos,
    return call_iter(iocb, &iter);
    }

    -static void nvmet_file_io_done(struct kiocb *iocb, long ret, long ret2)
    +static void nvmet_file_io_done(struct kiocb *iocb, long ret, long long ret2)
    {
    struct nvmet_req *req = container_of(iocb, struct nvmet_req, f.iocb);
    u16 status = NVME_SC_SUCCESS;
    diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c
    index 7143d03..387756f2 100644
    --- a/drivers/target/target_core_file.c
    +++ b/drivers/target/target_core_file.c
    @@ -243,7 +243,7 @@ struct target_core_file_cmd {
    struct kiocb iocb;
    };

    -static void cmd_rw_aio_complete(struct kiocb *iocb, long ret, long ret2)
    +static void cmd_rw_aio_complete(struct kiocb *iocb, long ret, long long ret2)
    {
    struct target_core_file_cmd *cmd;

    diff --git a/fs/aio.c b/fs/aio.c
    index 7ecddc2..7218c8b 100644
    --- a/fs/aio.c
    +++ b/fs/aio.c
    @@ -1418,7 +1418,7 @@ static void aio_remove_iocb(struct aio_kiocb *iocb)
    spin_unlock_irqrestore(&ctx->ctx_lock, flags);
    }

    -static void aio_complete_rw(struct kiocb *kiocb, long res, long res2)
    +static void aio_complete_rw(struct kiocb *kiocb, long res, long long res2)
    {
    struct aio_kiocb *iocb = container_of(kiocb, struct aio_kiocb, rw);

    diff --git a/fs/io_uring.c b/fs/io_uring.c
    index 155f3d8..7809ab2 100644
    --- a/fs/io_uring.c
    +++ b/fs/io_uring.c
    @@ -1958,7 +1958,7 @@ static void io_complete_rw_common(struct kiocb *kiocb, long res)
    __io_cqring_add_event(req, res, cflags);
    }

    -static void io_complete_rw(struct kiocb *kiocb, long res, long res2)
    +static void io_complete_rw(struct kiocb *kiocb, long res, long long res2)
    {
    struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb);

    @@ -1966,7 +1966,7 @@ static void io_complete_rw(struct kiocb *kiocb, long res, long res2)
    io_put_req(req);
    }

    -static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
    +static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long long res2)
    {
    struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb);

    diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
    index 01820e6..614b834 100644
    --- a/fs/overlayfs/file.c
    +++ b/fs/overlayfs/file.c
    @@ -268,7 +268,7 @@ static void ovl_aio_cleanup_handler(struct ovl_aio_req *aio_req)
    kmem_cache_free(ovl_aio_request_cachep, aio_req);
    }

    -static void ovl_aio_rw_complete(struct kiocb *iocb, long res, long res2)
    +static void ovl_aio_rw_complete(struct kiocb *iocb, long res, long long res2)
    {
    struct ovl_aio_req *aio_req = container_of(iocb,
    struct ovl_aio_req, iocb);
    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index ef13df4..a6a5f41 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -327,7 +327,7 @@ struct kiocb {
    randomized_struct_fields_start

    loff_t ki_pos;
    - void (*ki_complete)(struct kiocb *iocb, long ret, long ret2);
    + void (*ki_complete)(struct kiocb *iocb, long ret, long long ret2);
    void *private;
    int ki_flags;
    u16 ki_hint;
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-07-24 18:23    [W:2.088 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site