Messages in this thread | | | From | Srinivas Neeli <> | Subject | RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support | Date | Fri, 24 Jul 2020 14:56:11 +0000 |
| |
Hi Linus,
Thanks for the review
> -----Original Message----- > From: Linus Walleij <linus.walleij@linaro.org> > Sent: Friday, July 24, 2020 2:52 PM > To: kernel test robot <lkp@intel.com> > Cc: Srinivas Neeli <sneeli@xilinx.com>; Bartosz Golaszewski > <bgolaszewski@baylibre.com>; Michal Simek <michals@xilinx.com>; > Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas Goud > <sgoud@xilinx.com>; kbuild-all@lists.01.org; open list:GPIO SUBSYSTEM > <linux-gpio@vger.kernel.org>; Linux ARM <linux-arm- > kernel@lists.infradead.org>; linux-kernel@vger.kernel.org; git > <git@xilinx.com> > Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support > > On Fri, Jul 24, 2020 at 6:12 AM kernel test robot <lkp@intel.com> wrote: > > > drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe': > > drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member > named 'of_gpio_n_cells' > > 638 | chip->gc.of_gpio_n_cells = cells; > > | ^ > > >> drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no > member named 'of_xlate' > > 639 | chip->gc.of_xlate = xgpio_xlate; > > | ^ > > This is probably because your driver needs: > > depends on OF_GPIO > > in KConfig > I will address in v3.
> Yours, > Linus Walleij
| |