lkml.org 
[lkml]   [2020]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH RFC leds + net-next v2 1/1] net: phy: marvell: add support for PHY LEDs via LED class
    Hi!

    > > I expect some of this should be moved into the phylib core. We don't
    > > want each PHY inventing its own way to do this. The core should
    > > provide a framework and the PHY driver fills in the gaps.
    > >
    > > Take a look at for example mscc_main.c and its LED information. It has
    > > pretty similar hardware to the Marvell. And microchip.c also has LED
    > > handling, etc.
    >
    > OK, this makes sense. I will have to think about this a little.
    >
    > My main issue though is whether one "hw-control" trigger should be
    > registered via LED API and the specific mode should be chosen via
    > another sysfs file as in this RFC, or whether each HW control mode
    > should have its own trigger. The second solution would either result in
    > a lot of registered triggers or complicate LED API, though...

    If you register say 5 triggers.... that's okay. If you do like 1024
    additional triggers (it happened before!)... well please don't.

    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-07-24 12:24    [W:4.157 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site