lkml.org 
[lkml]   [2020]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] i2c: iproc: add slave pec support

> + /* Enable partial slave HW PEC support if requested by the client */
> + iproc_i2c->en_s_pec = !!(slave->flags & I2C_CLIENT_PEC);
> + if (iproc_i2c->en_s_pec)
> + dev_info(iproc_i2c->device, "Enable PEC\n");

Where do you set the I2C_CLIENT_PEC flag for the slave? Is your backend
code publicly available?

I may need a second thought here, but I am not sure I2C_CLIENT_PEC is
the right way to enable PEC. Isn't it actually depending on the backend
if PEC is needed? I.e. is the backend an I2C device or an SMBus device?

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-07-23 22:21    [W:0.217 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site