Messages in this thread | | | From | Jagan Teki <> | Date | Thu, 23 Jul 2020 12:04:12 +0530 | Subject | Re: [PATCH v2 3/6] dt-bindings: arm: rockchip: Add ROCKPi 4B binding |
| |
Hi Heiko,
On Thu, Jul 23, 2020 at 4:43 AM Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Jagan, > > Am Mittwoch, 22. Juli 2020, 21:09:46 CEST schrieb Jagan Teki: > > Add dt-bindings for ROCKPi 4B which is similar to 4A with > > additional AP6256 Wifi/BT, PoE. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index 36057c9e4b83..7250adb43d24 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -448,6 +448,12 @@ properties: > > - const: radxa,rockpi4a > > - const: rockchip,rk3399 > > > > + - description: Radxa ROCK Pi 4B > > + items: > > + - const: radxa,rockpi4 > > + - const: radxa,rockpi4b > > + - const: rockchip,rk3399 > > + > > Please do all RockPi4 variants into one entry, so we want something like: > > - description: Radxa ROCK Pi 4
What if the description has something like below.
- description: Radxa ROCK Pi 4A/B/C
Jagan.
| |