lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V6 09/14] perf/x86/intel: Support TopDown metrics on Ice Lake
From
Date


On 7/21/2020 10:31 AM, peterz@infradead.org wrote:
> On Tue, Jul 21, 2020 at 10:23:36AM -0400, Liang, Kan wrote:
>
>> Patch 13 forces the slots event to be part of a metric group. In patch 7,
>> for a metric group, we only update the values once with slots event.
>> I think the normal case mentioned above should not happen.
>>
>> + /* Only need to call update_topdown_event() once for group read. */
>> + if ((cpuc->txn_flags & PERF_PMU_TXN_READ) &&
>> + !is_slots_event(event))
>> + return;
>> +
>> + perf_pmu_disable(event->pmu);
>> + x86_pmu.update_topdown_event(event);
>> + perf_pmu_enable(event->pmu);
>
> Ah, I missed that.
>
> That also requires SLOTS to be the leader so that it will be the first
> read. Did we enforce that somewhere?

I think it's missed in the current patch set. The suggested code in
patch 11 forces SLOTS to be the leader. I will apply it in V7.

Thanks,
Kan

\
 
 \ /
  Last update: 2020-07-21 17:51    [W:0.049 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site