Messages in this thread | | | Date | Tue, 21 Jul 2020 12:44:42 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 08/11] driver-core: Introduce DEVICE_ATTR_ADMIN_{RO,RW} |
| |
On Mon, Jul 20, 2020 at 03:08:07PM -0700, Dan Williams wrote: > A common pattern for using plain DEVICE_ATTR() instead of > DEVICE_ATTR_RO() and DEVICE_ATTR_RW() is for attributes that want to > limit read to only root. I.e. many users of DEVICE_ATTR() are > specifying 0400 or 0600 for permissions. > > Given the expectation that CAP_SYS_ADMIN is needed to access these > sensitive attributes add an explicit helper with the _ADMIN_ identifier > for DEVICE_ATTR_ADMIN_{RO,RW}. > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > include/linux/device.h | 4 ++++ > include/linux/sysfs.h | 7 +++++++ > 2 files changed, 11 insertions(+)
This is 3022c6a1b4b7 ("driver-core: Introduce DEVICE_ATTR_ADMIN_{RO,RW}") in linux-next now, if anyone cared :)
thanks,
greg k-h
| |