Messages in this thread | | | Date | Tue, 21 Jul 2020 10:53:53 +0200 | From | Greg KH <> | Subject | Re: [PATCH] drivers: modules: remove set but not used variable 'no_warn' |
| |
On Tue, Jul 21, 2020 at 04:41:44PM +0800, Zheng Yongjun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/base/module.c: In function 'module_add_driver': > drivers/base/module.c:33: warning: > variable 'no_warn' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> > --- > drivers/base/module.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/base/module.c b/drivers/base/module.c > index 46ad4d636731..d1060c504c1b 100644 > --- a/drivers/base/module.c > +++ b/drivers/base/module.c > @@ -33,7 +33,6 @@ static void module_create_drivers_dir(struct module_kobject *mk) > void module_add_driver(struct module *mod, struct device_driver *drv) > { > char *driver_name; > - int no_warn; > struct module_kobject *mk = NULL; > > if (!drv) > @@ -59,11 +58,11 @@ void module_add_driver(struct module *mod, struct device_driver *drv) > return; > > /* Don't check return codes; these calls are idempotent */ > - no_warn = sysfs_create_link(&drv->p->kobj, &mk->kobj, "module"); > + sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
So you fix one warning for another one? Did you test build this change?
| |