lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 4/9] usb: cdns3: drd: return IRQ_NONE explicitly.
Date
On 20-07-13 12:05:49, Pawel Laszczak wrote:
> IRQ_NONE can be returned indirect.
>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

Reviewed-by: Peter Chen <peter.chen@nxp.com>

> ---
> drivers/usb/cdns3/drd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 6d2da504ad49..05a9f7d54c46 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -279,12 +279,12 @@ static irqreturn_t cdns3_drd_irq(int irq, void *data)
> u32 reg;
>
> if (cdns->dr_mode != USB_DR_MODE_OTG)
> - return ret;
> + return IRQ_NONE;
>
> reg = readl(&cdns->otg_regs->ivect);
>
> if (!reg)
> - return ret;
> + return IRQ_NONE;
>
> if (reg & OTGIEN_ID_CHANGE_INT) {
> dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n",
> --
> 2.17.1
>

--

Thanks,
Peter Chen
\
 
 \ /
  Last update: 2020-07-22 02:37    [W:0.141 / U:26.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site