Messages in this thread | | | Subject | Re: [PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver | From | Dan Murphy <> | Date | Tue, 21 Jul 2020 19:05:13 -0500 |
| |
Pavel
On 7/21/20 4:07 PM, Pavel Machek wrote: > On Thu 2020-07-16 13:19:58, Dan Murphy wrote: >> Introduce the LP5036/30/24/18/12/9 RGB LED driver. >> The difference in these parts are the number of >> LED outputs where the: >> >> LP5036 can control 36 LEDs >> LP5030 can control 30 LEDs >> LP5024 can control 24 LEDs >> LP5018 can control 18 LEDs >> LP5012 can control 12 LEDs >> LP5009 can control 9 LEDs >> >> The device has the ability to group LED output into control banks >> so that multiple LED banks can be controlled with the same mixing and >> brightness. Inversely the LEDs can also be controlled independently. >> >> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> +/* >> + * struct lp50xx_chip_info - >> + * @num_leds: number of LED outputs available on the device >> + * @led_brightness0_reg: first brightness register of the device >> + * @mix_out0_reg: first color mix register of the device >> + * @bank_brt_reg: bank brightness register >> + * @bank_mix_reg: color mix register >> + * @reset_reg: device reset register >> + */ > Should have /** if this is kerneldoc. > >> + init_data.fwnode = child; >> + num_colors = 0; >> + >> + /* There are only 3 LEDs per module otherwise they should be >> + * banked which also is presented as 3 LEDs >> + */ > This is not usual comment style for kernel. (And add . at end of > sentence).
I will fix both.
Dan
> Best regards, > Pavel
| |