lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] kernel: add a kernel_wait helper
    On Tue, 21 Jul 2020 15:04:49 +0200 Christoph Hellwig <hch@lst.de> wrote:

    > Add a helper that waits for a pid and stores the status in the passed
    > in kernel pointer. Use it to fix the usage of kernel_wait4 in
    > call_usermodehelper_exec_sync that only happens to work due to the
    > implicit set_fs(KERNEL_DS) for kernel threads.

    I guess it's cleaner, although it's a bit sad to be adding code to
    address a non-problem.

    Did you consider a simpler kernel_wait() which just wraps a
    set_fs(KERNEL_DS) around a call to kernel_wait4()?

    \
     
     \ /
      Last update: 2020-07-21 23:20    [W:2.434 / U:0.492 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site