lkml.org 
[lkml]   [2020]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/24] devtmpfs: open code ksys_chdir and ksys_chroot
On Tue, Jul 21, 2020 at 06:16:27PM +0100, Al Viro wrote:
> On Tue, Jul 21, 2020 at 09:49:17AM -0700, Linus Torvalds wrote:
> > On Tue, Jul 21, 2020 at 9:28 AM Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > +
> > > + /* traverse into overmounted root and then chroot to it */
> > > + if (!kern_path("/..", LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path) &&
> > > + !inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_CHDIR) &&
> > > + ns_capable(current_user_ns(), CAP_SYS_CHROOT) &&
> > > + !security_path_chroot(&path)) {
> > > + set_fs_pwd(current->fs, &path);
> > > + set_fs_root(current->fs, &path);
> > > + }
> > > + path_put(&path);
> >
> > This looks wrong.
>
> It is wrong. kern_path() leaves *path unmodified in case of error, and
> that struct path is uninitialized here.

Yep. Only saving grace is that the error just doesn't happen during
early init.

\
 
 \ /
  Last update: 2020-07-21 20:26    [W:0.061 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site