Messages in this thread | | | Subject | Re: [PATCH] staging: dpaa2-ethsw: fix switch/case fallthrough warning | From | Joe Perches <> | Date | Sun, 19 Jul 2020 23:09:25 -0700 |
| |
On Mon, 2020-07-20 at 08:30 +0300, Marian Posteuca wrote: > Fix the fallthrough warning that is reported by checkpatch. > > Signed-off-by: Marian Posteuca <posteuca@mutex.one> > --- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c > index 2fb75a7c9314..4986591097dc 100644 > --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c > +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c > @@ -1362,7 +1362,8 @@ static int port_switchdev_blocking_event(struct notifier_block *unused, > return NOTIFY_DONE; > > switch (event) { > - case SWITCHDEV_PORT_OBJ_ADD: /* fall through */ > + case SWITCHDEV_PORT_OBJ_ADD: > + fallthrough;
This comment is better removed instead of converted to fallthrough;
It's no different than a multiple case block like:
switch (val) { case FOO: case BAR: foobar(); break; default: return baz; }
etc...
| |