lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2] dt-bindings: hwmon: adm1272: add analog-temperature1-enable binding
On Mon, Jul 20, 2020 at 08:14:22PM +0000, Chu Lin wrote:
> Problem:
> adm1272 and adm1278 supports temperature sampling. The
> current way of enabling it requires the user manually unbind the device
> from the driver, flip the temperature sampling control bit and then bind
> the device back to the driver. It would be nice if we can control this in a
> better way by reading the dt.
>
> Solution:
> Introducing device tree binding analog-temperature1-enable. If the
> flag is set, flip the temp1_en control bit on probing.
>
> Testing:
> make dt_binding_check
>
> Signed-off-by: Chu Lin <linchuyuan@google.com>
> ---
> ChangeLog v1->v2:
> - Rename adm1272-adm1278-temp1-en to analog-temperature1-enable

This needs to be either analog,temperature1-enable or analog,temp1-enable
(comma instead of '-').

Thanks,
Guenter

>
> Documentation/devicetree/bindings/hwmon/adm1275.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> index 1ecd03f3da4d..7a345c7794a2 100644
> --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt
> +++ b/Documentation/devicetree/bindings/hwmon/adm1275.txt
> @@ -15,6 +15,8 @@ Optional properties:
>
> - shunt-resistor-micro-ohms
> Shunt resistor value in micro-Ohm
> +- analog-temperature1-enable
> + Enable temperature sampling. This is supported on adm1272 and adm1278
>
> Example:
>
> @@ -22,4 +24,5 @@ adm1272@10 {
> compatible = "adi,adm1272";
> reg = <0x10>;
> shunt-resistor-micro-ohms = <500>;
> + analog-temperature1-enable;
> };
> --
> 2.28.0.rc0.105.gf9edc3c819-goog
>

\
 
 \ /
  Last update: 2020-07-21 01:43    [W:1.009 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site