Messages in this thread | | | Date | Tue, 21 Jul 2020 05:21:02 +0800 | From | kernel test robot <> | Subject | Re: [PATCH 7/7] soc: imx8: Add the SC SECVIO driver |
| |
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next] [also build test WARNING on linux/master linus/master v5.8-rc6] [cannot apply to shawnguo/for-next next-20200720] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/franck-lenormand-oss-nxp-com/Add-support-of-SECVIO-from-SNVS-on-iMX8q-x/20200720-171044 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: x86_64-allyesconfig (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cf1105069648446d58adfb7a6cc590013d6886ba) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/soc/imx/secvio/imx-secvio-sc.c:200:5: warning: no previous prototype for function 'int_imx_secvio_sc_check_state' [-Wmissing-prototypes] int int_imx_secvio_sc_check_state(struct device *dev) ^ drivers/soc/imx/secvio/imx-secvio-sc.c:200:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int int_imx_secvio_sc_check_state(struct device *dev) ^ static 1 warning generated. -- >> drivers/soc/imx/secvio/imx-secvio-debugfs.c:45:5: warning: no previous prototype for function 'fuse_reader' [-Wmissing-prototypes] int fuse_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ drivers/soc/imx/secvio/imx-secvio-debugfs.c:45:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int fuse_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ static >> drivers/soc/imx/secvio/imx-secvio-debugfs.c:78:5: warning: no previous prototype for function 'snvs_reader' [-Wmissing-prototypes] int snvs_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ drivers/soc/imx/secvio/imx-secvio-debugfs.c:78:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int snvs_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ static >> drivers/soc/imx/secvio/imx-secvio-debugfs.c:129:5: warning: no previous prototype for function 'snvs_dgo_reader' [-Wmissing-prototypes] int snvs_dgo_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ drivers/soc/imx/secvio/imx-secvio-debugfs.c:129:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int snvs_dgo_reader(struct device *dev, u32 id, u32 *value, u8 mul) ^ static 3 warnings generated. -- >> drivers/soc/imx/secvio/imx-secvio-audit.c:23:5: warning: no previous prototype for function 'report_to_audit_notify' [-Wmissing-prototypes] int report_to_audit_notify(struct notifier_block *nb, unsigned long status, ^ drivers/soc/imx/secvio/imx-secvio-audit.c:23:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int report_to_audit_notify(struct notifier_block *nb, unsigned long status, ^ static 1 warning generated.
vim +/int_imx_secvio_sc_check_state +200 drivers/soc/imx/secvio/imx-secvio-sc.c
189 190 /** 191 * int_imx_secvio_sc_check_state() - Get the state and call chain of notifier 192 * if there is a status 193 * 194 * @dev: secvio device 195 * 196 * Return: 197 * 0 - OK 198 * < 0 - error. 199 */ > 200 int int_imx_secvio_sc_check_state(struct device *dev) 201 { 202 struct secvio_sc_notifier_info info = {0}; 203 int ret = 0; 204 205 ret = int_imx_secvio_sc_get_state(dev, &info); 206 if (ret) { 207 dev_err(dev, "Failed to get secvio state\n"); 208 goto exit; 209 } 210 211 /* Call chain of CB registered to this module if status detected */ 212 if (info.hpsvs || info.lps || info.lptds) 213 if (imx_secvio_sc_notifier_call_chain(&info)) 214 dev_warn(dev, 215 "Issues when calling the notifier chain\n"); 216 217 exit: 218 return ret; 219 } 220
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |