lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] media: v4l2-dev/ioctl: Fix document for VIDIOC_QUERYCAP
From
Date
Hi,

On 7/20/20 6:29 AM, Jian-Jia Su wrote:
> V4L2_CAP_VIDEO_M2M is documented as 0x00004000
> V4L2_CAP_VIDEO_M2M_MPLANE is documented as 0x00008000
> This is different from the definition in include/uapi/linux/videodev2.h
>

Nice catch, they are swapped in the docs indeed.

From videodev2.h:

/* Is a video mem-to-mem device that supports multiplanar formats */
#define V4L2_CAP_VIDEO_M2M_MPLANE 0x00004000
/* Is a video mem-to-mem device */
#define V4L2_CAP_VIDEO_M2M 0x00008000

> Signed-off-by: Jian-Jia Su <jjsu@chromium.org>

Reviewed-by: Helen Koike <helen.koike@collabora.com>

Regards,
Helen

> ---
> Documentation/userspace-api/media/v4l/vidioc-querycap.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-querycap.rst b/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> index 666ac4d420519..90347367ef06a 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> @@ -168,11 +168,11 @@ specification the ioctl returns an ``EINVAL`` error code.
> - The device supports the :ref:`multi-planar API <planar-apis>`
> through the :ref:`Video Output <output>` interface.
> * - ``V4L2_CAP_VIDEO_M2M``
> - - 0x00004000
> + - 0x00008000
> - The device supports the single-planar API through the Video
> Memory-To-Memory interface.
> * - ``V4L2_CAP_VIDEO_M2M_MPLANE``
> - - 0x00008000
> + - 0x00004000
> - The device supports the :ref:`multi-planar API <planar-apis>`
> through the Video Memory-To-Memory interface.
> * - ``V4L2_CAP_VIDEO_OVERLAY``
>

\
 
 \ /
  Last update: 2020-07-20 21:46    [W:0.043 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site