lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 055/125] drm/exynos: fix ref count leak in mic_pre_enable
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ]

    in mic_pre_enable, pm_runtime_get_sync is called which
    increments the counter even in case of failure, leading to incorrect
    ref count. In case of failure, decrement the ref count before returning.

    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: Inki Dae <inki.dae@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
    index ba4a32b132baa..59ce068b152f5 100644
    --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
    +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
    @@ -267,8 +267,10 @@ static void mic_pre_enable(struct drm_bridge *bridge)
    goto unlock;

    ret = pm_runtime_get_sync(mic->dev);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put_noidle(mic->dev);
    goto unlock;
    + }

    mic_set_path(mic, 1);

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 19:10    [W:4.201 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site