lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 123/133] thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power
    Date
    From: Finley Xiao <finley.xiao@rock-chips.com>

    commit 371a3bc79c11b707d7a1b7a2c938dc3cc042fffb upstream.

    The function cpu_power_to_freq is used to find a frequency and set the
    cooling device to consume at most the power to be converted. For example,
    if the power to be converted is 80mW, and the em table is as follow.
    struct em_cap_state table[] = {
    /* KHz mW */
    { 1008000, 36, 0 },
    { 1200000, 49, 0 },
    { 1296000, 59, 0 },
    { 1416000, 72, 0 },
    { 1512000, 86, 0 },
    };
    The target frequency should be 1416000KHz, not 1512000KHz.

    Fixes: 349d39dc5739 ("thermal: cpu_cooling: merge frequency and power tables")
    Cc: <stable@vger.kernel.org> # v4.13+
    Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
    Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
    Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Link: https://lore.kernel.org/r/20200619090825.32747-1-finley.xiao@rock-chips.com
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/thermal/cpu_cooling.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/thermal/cpu_cooling.c
    +++ b/drivers/thermal/cpu_cooling.c
    @@ -278,11 +278,11 @@ static u32 cpu_power_to_freq(struct cpuf
    int i;
    struct freq_table *freq_table = cpufreq_cdev->freq_table;

    - for (i = 1; i <= cpufreq_cdev->max_level; i++)
    - if (power > freq_table[i].power)
    + for (i = 0; i < cpufreq_cdev->max_level; i++)
    + if (power >= freq_table[i].power)
    break;

    - return freq_table[i - 1].frequency;
    + return freq_table[i].frequency;
    }

    /**

    \
     
     \ /
      Last update: 2020-07-20 19:10    [W:4.496 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site