lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 073/244] scsi: qla2xxx: make 1-bit bit-fields unsigned int
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 78b874b7cbf09fbfadfa5f18a347ebef7bbb49fe ]

    The bitfields mpi_fw_dump_reading and mpi_fw_dumped are currently signed
    which is not recommended as the representation is an implementation defined
    behaviour. Fix this by making the bit-fields unsigned ints.

    Link: https://lore.kernel.org/r/20200428102013.1040598-1-colin.king@canonical.com
    Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
    Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/qla2xxx/qla_def.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
    index daa9e936887bb..172ea4e5887d9 100644
    --- a/drivers/scsi/qla2xxx/qla_def.h
    +++ b/drivers/scsi/qla2xxx/qla_def.h
    @@ -4248,8 +4248,8 @@ struct qla_hw_data {
    int fw_dump_reading;
    void *mpi_fw_dump;
    u32 mpi_fw_dump_len;
    - int mpi_fw_dump_reading:1;
    - int mpi_fw_dumped:1;
    + unsigned int mpi_fw_dump_reading:1;
    + unsigned int mpi_fw_dumped:1;
    int prev_minidump_failed;
    dma_addr_t eft_dma;
    void *eft;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-20 18:11    [W:4.065 / U:0.960 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site