lkml.org 
[lkml]   [2020]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 158/215] usb: gadget: function: fix missing spinlock in f_uac1_legacy
    Date
    From: Zhang Qiang <qiang.zhang@windriver.com>

    commit 8778eb0927ddcd3f431805c37b78fa56481aeed9 upstream.

    Add a missing spinlock protection for play_queue, because
    the play_queue may be destroyed when the "playback_work"
    work func and "f_audio_out_ep_complete" callback func
    operate this paly_queue at the same time.

    Fixes: c6994e6f067cf ("USB: gadget: add USB Audio Gadget driver")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/function/f_uac1_legacy.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/usb/gadget/function/f_uac1_legacy.c
    +++ b/drivers/usb/gadget/function/f_uac1_legacy.c
    @@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struc

    /* Copy buffer is full, add it to the play_queue */
    if (audio_buf_size - copy_buf->actual < req->actual) {
    + spin_lock_irq(&audio->lock);
    list_add_tail(&copy_buf->list, &audio->play_queue);
    + spin_unlock_irq(&audio->lock);
    schedule_work(&audio->playback_work);
    copy_buf = f_audio_buffer_alloc(audio_buf_size);
    if (IS_ERR(copy_buf))

    \
     
     \ /
      Last update: 2020-07-20 18:03    [W:6.773 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site