Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] staging/wilc1000: let wilc_mac_xmit() to NETDEV_TX_OK | Date | Thu, 02 Jul 2020 09:48:59 +0300 |
| |
<Nicolas.Ferre@microchip.com> writes:
> Luc, > > Thanks for your patch... > > On 28/06/2020 at 20:32, Luc Van Oostenryck wrote: >> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', >> which is a typedef for an enum type defining 'NETDEV_TX_OK' but this >> driver returns '0' instead of 'NETDEV_TX_OK'. >> >> Fix this by returning ''NETDEV_TX_OK' instead of 0. >> >> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> >> --- >> drivers/staging/wilc1000/netdev.c | 6 +++--- > > ... would it be possible that you re-spin it so that it applies to the > new location of this driver: > drivers/net/wireless/microchip/wilc1000/netdev.c > > You can rebase your patch on the wireless-driver-next tree with > wilc1000-move-out-of-staging branch: > > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git > branch: wilc1000-move-out-of-staging > > (Then you can also review the subject line of your patch, BTW)
And also cc linux-wireless so that our patchwork sees it (not sure if the original patch had it or not, just making sure), more info in the link below.
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |