Messages in this thread | | | Date | Thu, 2 Jul 2020 08:01:15 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema |
| |
On Tue, Jun 30, 2020 at 09:34:52AM +0200, Marek Szyprowski wrote: > Hi Krzysztof, > > On 29.06.2020 22:44, Krzysztof Kozlowski wrote: > > AMBA is a bus so name the node with DMA controllers just as "bus" to fix > > dtschema warnings like: > > > > amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > Do we really need a separate 'bus' for those DMA controllers? > > IMHO they are not different from the hw perspective from the other > devices available on the SoC. A separate bus is a historical thing, they > work fine when moved directly under the 'soc' node. The separate bus > only mimics the way Linux organizes its drivers. This comment affects > both ARM and ARM64.
Good point, other boards keep them under SoC usually. Thanks for feedback.
Best regards, Krzysztof
| |