lkml.org 
[lkml]   [2020]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema
On Tue, Jun 30, 2020 at 09:34:52AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.06.2020 22:44, Krzysztof Kozlowski wrote:
> > AMBA is a bus so name the node with DMA controllers just as "bus" to fix
> > dtschema warnings like:
> >
> > amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Do we really need a separate 'bus' for those DMA controllers?
>
> IMHO they are not different from the hw perspective from the other
> devices available on the SoC. A separate bus is a historical thing, they
> work fine when moved directly under the 'soc' node. The separate bus
> only mimics the way Linux organizes its drivers. This comment affects
> both ARM and ARM64.

Good point, other boards keep them under SoC usually. Thanks for
feedback.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-07-02 08:01    [W:0.067 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site