lkml.org 
[lkml]   [2020]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] platform/x86: thinkpad_acpi: not loading brightness_init when _BCL invalid
    On Thu, Jul 2, 2020 at 1:51 PM Aaron Ma <aaron.ma@canonical.com> wrote:
    > On 7/2/20 5:30 PM, Andy Shevchenko wrote:
    > > On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron.ma@canonical.com> wrote:
    > >>
    > >> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
    > >>
    > >> brightness_enable is already checked at the beginning,
    > >
    > >> Always print notice when enabled brightness control.
    > >
    > > Why?
    > >
    >
    > Default brightness_enable = 2, so this message will always be printed as before
    > Actually no change here.
    >
    > > ...
    > >
    > >> + pr_notice("thinkpad_acpi native brightness control enabled\n");
    > >
    > > 'notice' level is quite high, why do we spam users with this?
    > >
    >
    > Like above.
    >
    > Another reason is most thinkpads are using native gpu driver to control
    > brightness, notice when thinkpad_acpi brightness is enabled.

    So, based on the above, please elaborate and explain all this in the
    commit message of new version, thanks!

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2020-07-02 13:00    [W:3.162 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site