lkml.org 
[lkml]   [2020]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: rts5208: rtsx: Replace depracated MSI API
On Sat, Jul 18, 2020 at 09:10:30PM +0530, Suraj Upadhyay wrote:
> Replace depracated pci_enable_msi with pci_alloc_irq_vectors.
>
> Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> ---
> drivers/staging/rts5208/rtsx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Hii, don't merge this patch.
It is still incomplete.
It doesn't replace pci_disable_msi.
I hope this didn't cause any annoyances.

Thanks,

Suraj Upadhyay.

> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index e28e162d004e..b39d3f8b54df 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -310,7 +310,7 @@ static int __maybe_unused rtsx_resume(struct device *dev_d)
> pci_set_master(pci);
>
> if (chip->msi_en) {
> - if (pci_enable_msi(pci) < 0)
> + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0)
> chip->msi_en = 0;
> }
>
> @@ -881,7 +881,7 @@ static int rtsx_probe(struct pci_dev *pci,
> dev_info(&pci->dev, "pci->irq = %d\n", pci->irq);
>
> if (dev->chip->msi_en) {
> - if (pci_enable_msi(pci) < 0)
> + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0)
> dev->chip->msi_en = 0;
> }
>
> --
> 2.17.1
>


\
 
 \ /
  Last update: 2020-07-19 06:37    [W:0.031 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site