Messages in this thread | | | Date | Sat, 18 Jul 2020 16:48:17 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 12/30] iio: dac: ad5504: Fix formatting errors and demote non-compliant kerneldoc |
| |
On Fri, 17 Jul 2020 17:55:20 +0100 Lee Jones <lee.jones@linaro.org> wrote:
> Kerneldoc expects attributes/parameters to be in '@*.: ' format. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mask' not described in 'ad5504_state' > drivers/iio/dac/ad5504.c:58: warning: Function parameter or member 'pwr_down_mode' not described in 'ad5504_state' > drivers/iio/dac/ad5504.c:64: warning: cannot understand function prototype: 'enum ad5504_supported_device_ids ' > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied.
Thanks,
Jonathan
> --- > drivers/iio/dac/ad5504.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c > index c64e6898ff20a..7e4e422ddfefc 100644 > --- a/drivers/iio/dac/ad5504.c > +++ b/drivers/iio/dac/ad5504.c > @@ -43,8 +43,8 @@ > * @spi: spi_device > * @reg: supply regulator > * @vref_mv: actual reference voltage used > - * @pwr_down_mask power down mask > - * @pwr_down_mode current power down mode > + * @pwr_down_mask: power down mask > + * @pwr_down_mode: current power down mode > * @data: transfer buffer > */ > struct ad5504_state { > @@ -57,10 +57,9 @@ struct ad5504_state { > __be16 data[2] ____cacheline_aligned; > }; > > -/** > +/* > * ad5504_supported_device_ids: > */ > - > enum ad5504_supported_device_ids { > ID_AD5504, > ID_AD5501,
| |