Messages in this thread | | | Date | Fri, 17 Jul 2020 15:40:08 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: ethernet: et131x: Remove redundant register read |
| |
On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote: > Following the removal of an unused variable assignment (remove > unused variable 'pm_csr') the associated register read can also go, > as the read also occurs in the subsequent et1310_in_phy_coma() > call.
Hi Mark
Do you have any hardware documentation which indicates these read are not required? Have you looked back through the git history to see if there are any comments about these read?
Hardware reads which appear pointless are sometimes very important to actually make the hardware work.
Andrew
| |