lkml.org 
[lkml]   [2020]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [PATCH] Firmware security information in SYSFS
On Thu, Jul 16, 2020 at 07:36:27PM -0300, Daniel Gutson wrote:
> +What: /sys/kernel/firmware-security/bioswe

Ick, I stopped reading right here.

No, this is not where this belongs.

We already have /sys/firmware/, right? And firmware-specific
subdirectories below that.

We also have /sys/devices/system/ and I think that would be a much
better place for this, as it is easier to work with a real 'struct
device' than a "raw" kobject any day. Bonus is you get full support of
userspace libraries when you do that, unlike when dealing with kobjects.

Also, this really is a _SPECIFIC_ type of firmware that supports these
features, right? Why not call that out too? This is not generic by any
means.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-07-17 08:29    [W:0.134 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site