lkml.org 
[lkml]   [2020]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX
    Hi Bixuan,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on sparc-next/master]
    [also build test ERROR on net-next/master net/master linus/master v5.8-rc5 next-20200716]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Bixuan-Cui/net-neterion-vxge-reduce-stack-usage-in-VXGE_COMPLETE_VPATH_TX/20200716-173219
    base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next.git master
    config: arc-allyesconfig (attached as .config)
    compiler: arc-elf-gcc (GCC) 9.3.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    drivers/net/ethernet/neterion/vxge/vxge-main.c: In function 'VXGE_COMPLETE_VPATH_TX':
    >> drivers/net/ethernet/neterion/vxge/vxge-main.c:103:19: error: conflicting types for 'completed'
    103 | struct sk_buff **completed;
    | ^~~~~~~~~
    drivers/net/ethernet/neterion/vxge/vxge-main.c:102:18: note: previous declaration of 'completed' was here
    102 | struct sk_buff *completed[NR_SKB_COMPLETED];
    | ^~~~~~~~~
    >> drivers/net/ethernet/neterion/vxge/vxge-main.c:126:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
    126 | free(completed);
    | ^~~~
    drivers/net/ethernet/neterion/vxge/vxge-main.c:60:1: note: 'free' is defined in header '<stdlib.h>'; did you forget to '#include <stdlib.h>'?
    59 | #include "vxge-main.h"
    +++ |+#include <stdlib.h>
    60 | #include "vxge-reg.h"
    cc1: some warnings being treated as errors

    vim +/completed +103 drivers/net/ethernet/neterion/vxge/vxge-main.c

    96
    97 static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo)
    98 {
    99 struct sk_buff **skb_ptr = NULL;
    100 struct sk_buff **temp;
    101 #define NR_SKB_COMPLETED 128
    102 struct sk_buff *completed[NR_SKB_COMPLETED];
    > 103 struct sk_buff **completed;
    104 int more;
    105
    106 completed = kcalloc(NR_SKB_COMPLETED, sizeof(*completed),
    107 GFP_KERNEL);
    108 if (!completed)
    109 return;
    110
    111 do {
    112 more = 0;
    113 skb_ptr = completed;
    114
    115 if (__netif_tx_trylock(fifo->txq)) {
    116 vxge_hw_vpath_poll_tx(fifo->handle, &skb_ptr,
    117 NR_SKB_COMPLETED, &more);
    118 __netif_tx_unlock(fifo->txq);
    119 }
    120
    121 /* free SKBs */
    122 for (temp = completed; temp != skb_ptr; temp++)
    123 dev_consume_skb_irq(*temp);
    124 } while (more);
    125
    > 126 free(completed);
    127 }
    128

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2020-07-16 16:17    [W:2.811 / U:1.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site