[lkml]   [2020]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] locking/pvqspinlock: Optionally store lock holder cpu into lock
On 7/14/20 5:01 AM, Peter Zijlstra wrote:
> On Mon, Jul 13, 2020 at 10:48:00PM -0400, Waiman Long wrote:
>> Storing the cpu number into the lock can be useful for other reason too. It
>> is not totally related to PPC support.
> Well, the thing you did only works for 'small' (<253 CPU) systems.
> There's a number of Power systems that's distinctly larger than that. So
> it simply cannot work as anything other than a suggestion/hint. It must
> not be a correctness thing.
Yes, there are limit on how much data one can put into the lock byte. So
it is not a sure way to find out who the lock holder is. There are
certainly large systems with hundreds or even thousands of cpus, but
they are the minority in the sea of Linux systems out there.

If the lock holder goes through the slowpath, the one behind it can save
its cpu number which can be used a hint of who the lock holder is though
it is not that reliable as lock stealing can happen.

BTW, I did get the optimized PV unlock asm code working now. I will post
the updated unconditional patch later this week for further discussion.


 \ /
  Last update: 2020-07-15 18:33    [W:0.069 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site