lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/percpu: mark pcpu_chunk_type() as __maybe_unused
From
Date


On 2020/7/14 20:53, Stephen Rothwell wrote:
> Hi Bixuan,
>
> On Tue, 14 Jul 2020 13:41:01 +0000 Bixuan Cui <cuibixuan@huawei.com> wrote:
>> Gcc report the following warning without CONFIG_MEMCG_KMEM:
>>
>> mm/percpu-internal.h:145:29: warning: ‘pcpu_chunk_type’ defined
>> but not used [-Wunused-function]
>> static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk)
>> ^~~~~~~~~~~~~~~
>>
>> Mark pcpu_chunk_type() as __maybe_unused to make it clear.
> Given that it is in a header file, it should probably just be "static
> inline" (which will also suppress the warning). As should
> pcpu_is_memcg_chunk() and pcpu_chunk_list(). Also, without them being
> inline, there will be a new copy for each file that
> mm/percpu-internal.h is included in.
>
> And that should be considered a fix for "mm: memcg/percpu: account
> percpu memory to memory cgroups".
Thinks,i will fix it.

\
 
 \ /
  Last update: 2020-07-14 15:34    [W:0.120 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site