lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] exec: Implement kernel_execve
    On Tue, Jul 14, 2020 at 08:31:40AM -0500, Eric W. Biederman wrote:
    > +static int count_strings_kernel(const char *const *argv)
    > +{
    > + int i;
    > +
    > + if (!argv)
    > + return 0;
    > +
    > + for (i = 0; argv[i]; ++i) {
    > + if (i >= MAX_ARG_STRINGS)
    > + return -E2BIG;
    > + if (fatal_signal_pending(current))
    > + return -ERESTARTNOHAND;
    > + cond_resched();
    > + }
    > + return i;
    > +}

    I notice count() is only ever called with MAX_ARG_STRINGS. Perhaps
    refactor that too? (And maybe rename it to count_strings_user()?)

    Otherwise, looks good:

    Reviewed-by: Kees Cook <keescook@chromium.org>

    --
    Kees Cook

    \
     
     \ /
      Last update: 2020-07-14 23:50    [W:4.185 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site