Messages in this thread | | | Date | Tue, 14 Jul 2020 22:03:40 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs |
| |
On Tue, 14 Jul 2020, Rafael J. Wysocki wrote:
> On Tue, Jul 14, 2020 at 4:51 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > Can't see them being used anywhere and the compiler doesn't complain > > that they're missing, so ... > > Aren't they needed for automatic module loading in certain configurations?
Any idea how that works, or where the code is for that?
> > Fixes the following W=1 kernel build warning(s): > > > > drivers/cpufreq/acpi-cpufreq.c:1004:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=] > > 997 | static const struct x86_cpu_id acpi_cpufreq_ids[] = { > > | ^~~~~~~~~~~~~~~~ > > drivers/cpufreq/acpi-cpufreq.c:997:32: warning: ‘acpi_cpufreq_ids’ defined but not used [-Wunused-const-variable=] > > 619 | static const struct acpi_device_id processor_device_ids[] = { > > | ^~~~~~~~~~~~~~~~~~~~ > > > > Cc: Andy Grover <andrew.grover@intel.com> > > Cc: Paul Diefenbaugh <paul.s.diefenbaugh@intel.com> > > Cc: Dominik Brodowski <linux@brodo.de> > > Cc: Denis Sadykov <denis.m.sadykov@intel.com> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/cpufreq/acpi-cpufreq.c | 14 -------------- > > 1 file changed, 14 deletions(-) > > > > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > > index d38a693b48e03..fc68f13352695 100644 > > --- a/drivers/cpufreq/acpi-cpufreq.c > > +++ b/drivers/cpufreq/acpi-cpufreq.c > > @@ -995,18 +995,4 @@ MODULE_PARM_DESC(acpi_pstate_strict, > > late_initcall(acpi_cpufreq_init); > > module_exit(acpi_cpufreq_exit); > > > > -static const struct x86_cpu_id acpi_cpufreq_ids[] = { > > - X86_MATCH_FEATURE(X86_FEATURE_ACPI, NULL), > > - X86_MATCH_FEATURE(X86_FEATURE_HW_PSTATE, NULL), > > - {} > > -}; > > -MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids); > > - > > -static const struct acpi_device_id processor_device_ids[] = { > > - {ACPI_PROCESSOR_OBJECT_HID, }, > > - {ACPI_PROCESSOR_DEVICE_HID, }, > > - {}, > > -}; > > -MODULE_DEVICE_TABLE(acpi, processor_device_ids); > > - > > MODULE_ALIAS("acpi"); > >
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |