lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
    On Tue, 14 Jul 2020 18:51:15 +0000 Westergreen, Dalon wrote:
    > > I've seen vendors abuse fields of ethtool --coalesce to configure
    > > similar settings. tx-usecs-irq and rx-usecs-irq, I think. Since this
    > > part of ethtool API has been ported to netlink, could we perhaps add
    > > a new field to ethtool --coalesce?
    >
    > I don't think this is necessary, i think just having a module parameter
    > meets our needs. I don't see a need for the value to change on a per
    > interface basis. This was primarily used during testing / bringup.

    It's hard to tell which knobs users will find worth turning therefore
    the testing / bringup justification unfortunately has little bearing on
    our upstream interface choices.

    We try hard to avoid module parameters in networking drivers, so if you
    want this tunable upstream a proper user interface will be required.

    \
     
     \ /
      Last update: 2020-07-14 21:14    [W:8.275 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site