lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 043/166] nfs: Fix memory leak of export_path
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 4659ed7cc8514369043053463514408ca16ad6f3 ]

    The try_location function is called within a loop by nfs_follow_referral.
    try_location calls nfs4_pathname_string to created the export_path.
    nfs4_pathname_string allocates the memory. export_path is stored in the
    nfs_fs_context/fs_context structure similarly as hostname and source.
    But whereas the ctx hostname and source are freed before assignment,
    export_path is not. So if there are multiple loops, the new export_path
    will overwrite the old without the old being freed.

    So call kfree for export_path.

    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/nfs/nfs4namespace.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c
    index a3ab6e219061b..873342308dc0d 100644
    --- a/fs/nfs/nfs4namespace.c
    +++ b/fs/nfs/nfs4namespace.c
    @@ -308,6 +308,7 @@ static int try_location(struct fs_context *fc,
    if (IS_ERR(export_path))
    return PTR_ERR(export_path);

    + kfree(ctx->nfs_server.export_path);
    ctx->nfs_server.export_path = export_path;

    source = kmalloc(len + 1 + ctx->nfs_server.export_path_len + 1,
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-07-14 21:06    [W:3.744 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site