lkml.org 
[lkml]   [2020]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs
    On Tue, Jul 14, 2020 at 4:51 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Can't see them being used anywhere and the compiler doesn't complain
    > that they're missing, so ...

    Autoloading of the module too.

    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/cpufreq/pcc-cpufreq.c:619:36: warning: ‘processor_device_ids’ defined but not used [-Wunused-const-variable=]
    > 619 | static const struct acpi_device_id processor_device_ids[] = {
    > | ^~~~~~~~~~~~~~~~~~~~
    >
    > Cc: Matthew Garrett <mjg@redhat.com>
    > Cc: Nagananda Chumbalkar <nagananda.chumbalkar@hp.com>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/cpufreq/pcc-cpufreq.c | 7 -------
    > 1 file changed, 7 deletions(-)
    >
    > diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
    > index 5789fe7a94bd3..99cf8b78c032a 100644
    > --- a/drivers/cpufreq/pcc-cpufreq.c
    > +++ b/drivers/cpufreq/pcc-cpufreq.c
    > @@ -616,13 +616,6 @@ static void __exit pcc_cpufreq_exit(void)
    > free_percpu(pcc_cpu_info);
    > }
    >
    > -static const struct acpi_device_id processor_device_ids[] = {
    > - {ACPI_PROCESSOR_OBJECT_HID, },
    > - {ACPI_PROCESSOR_DEVICE_HID, },
    > - {},
    > -};
    > -MODULE_DEVICE_TABLE(acpi, processor_device_ids);
    > -
    > MODULE_AUTHOR("Matthew Garrett, Naga Chumbalkar");
    > MODULE_VERSION(PCC_VERSION);
    > MODULE_DESCRIPTION("Processor Clocking Control interface driver");
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2020-07-14 19:43    [W:4.039 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site